Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge settings possible_values to range #14010

Merged
merged 12 commits into from
Dec 14, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Dec 14, 2023

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • merge possible_values into range
  • add range limit:[0, 1] for bool settings like enable_**
  • add range column to system.settings table
+------------------------------------------------+----------------+----------------+---------------------------------------------------+-----------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+
| Column 0                                       | Column 1       | Column 2       | Column 3                                          | Column 4  | Column 5                                                                                                                                                                              | Column 6 |
+------------------------------------------------+----------------+----------------+---------------------------------------------------+-----------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+
| 'acquire_lock_timeout'                         | '15'           | '15'           | 'None'                                            | 'SESSION' | 'Sets the maximum timeout in seconds for acquire a lock.'                                                                                                                             | 'UInt64' |
| 'aggregate_spilling_bytes_threshold_per_proc'  | '0'            | '0'            | 'None'                                            | 'SESSION' | 'Sets the maximum amount of memory in bytes that an aggregator can use before spilling data to storage during query execution.'                                                       | 'UInt64' |
| 'aggregate_spilling_memory_ratio'              | '0'            | '0'            | 'None'                                            | 'SESSION' | 'Sets the maximum memory ratio in bytes that an aggregator can use before spilling data to storage during query execution.'                                                           | 'UInt64' |
| 'collation'                                    | 'binary'       | 'binary'       | '["binary", "utf8"]'                              | 'SESSION' | 'Sets the character collation. Available values include "binary" and "utf8".'                                                                                                         | 'String' |
| 'create_query_flight_client_with_current_rt'   | '1'            | '1'            | 'None'                                            | 'SESSION' | 'create query flight client with current runtime'                                                                                                                                     | 'UInt64' |
| 'ddl_column_type_nullable'                     | '1'            | '1'            | 'None'                                            | 'SESSION' | 'If columns are default nullable when create or alter table'                                                                                                                          | 'UInt64' |
| 'disable_join_reorder'                         | '0'            | '0'            | 'None'                                            | 'SESSION' | 'Disable join reorder optimization.'                                                                                                                                                  | 'UInt64' |
| 'efficiently_memory_group_by'                  | '0'            | '0'            | 'None'                                            | 'SESSION' | 'Memory is used efficiently, but this may cause performance degradation.'                                                                                                             | 'UInt64' |
  • Closes #issue

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 14, 2023
@BohuTANG BohuTANG marked this pull request as ready for review December 14, 2023 05:37
@BohuTANG BohuTANG requested a review from zhang2014 December 14, 2023 05:37
@BohuTANG
Copy link
Member Author

The test is on fixing.

@BohuTANG BohuTANG merged commit 1d3828d into databendlabs:main Dec 14, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants