-
Notifications
You must be signed in to change notification settings - Fork 769
feat: show locks #14004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show locks #14004
Conversation
Also need sql logic tests for this feature, it will be useful as the unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 15 files at r1, 1 of 20 files at r2.
Reviewable status: 4 of 35 files reviewed, 1 unresolved discussion (waiting on @BohuTANG, @dantengsky, and @zhyass)
src/meta/api/src/schema_api_impl.rs
line 3485 at r3 (raw file):
let mut reply = vec![]; for prefix in &req.prefixes { let list = self.prefix_list_kv(prefix).await?;
Use list_kv()
instead of prefix_list_kv()
if possible.
list_kv()
returns a Stream
and won't be affected by the max gPRC message size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r4, all commit messages.
Reviewable status: 6 of 37 files reviewed, 1 unresolved discussion (waiting on @BohuTANG, @dantengsky, and @zhyass)
cc @soyeric128 for documenting this new feature. |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
This change is