-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: using borsh instead of bincode for serde agg function state #13997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
this PR changes the code base without new features or bugfix
label
Dec 12, 2023
sundy-li
reviewed
Dec 13, 2023
ariesdevil
force-pushed
the
agg-function
branch
from
December 13, 2023 05:02
1b86fed
to
82aa56a
Compare
What's the performance compare to bincode? |
I'm doing now, will be post to this PR later |
It seems that we don't need to worry about performance. |
I'll go on modify other state ser/deser |
BohuTANG
reviewed
Dec 13, 2023
BohuTANG
reviewed
Dec 13, 2023
ariesdevil
force-pushed
the
agg-function
branch
from
December 13, 2023 14:19
82aa56a
to
07dc05d
Compare
BohuTANG
reviewed
Dec 13, 2023
ariesdevil
force-pushed
the
agg-function
branch
from
December 13, 2023 15:23
f4de87d
to
95c6830
Compare
BohuTANG
reviewed
Dec 13, 2023
tests/sqllogictests/suites/query/02_function/02_0000_function_aggregate_state.test
Show resolved
Hide resolved
Docker Image for PR
|
ariesdevil
force-pushed
the
agg-function
branch
from
December 16, 2023 05:32
9898e75
to
67aa990
Compare
sundy-li
approved these changes
Dec 16, 2023
BohuTANG
reviewed
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-benchmark
Benchmark: run all test
pr-refactor
this PR changes the code base without new features or bugfix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
using borsh instead of bincode for serde agg function state
BTW: there are three crates that using my own patch version, after these merge to upstream, I'll update them to databend.
Tests
This change is