Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support maximum check #13992

Merged
merged 3 commits into from
Dec 13, 2023
Merged

feat: support maximum check #13992

merged 3 commits into from
Dec 13, 2023

Conversation

guojidan
Copy link
Contributor

@guojidan guojidan commented Dec 12, 2023 •
edited by BohuTANG
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Summary about this PR

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 12, 2023
@guojidan guojidan marked this pull request as draft December 12, 2023 09:08
@guojidan guojidan marked this pull request as ready for review December 13, 2023 04:10
@BohuTANG BohuTANG requested a review from zhang2014 December 13, 2023 04:49
@BohuTANG
Copy link
Member

👍
It's better to add a logic test to:
https://github.com/datafuselabs/databend/blob/193ed56304af71ece3be398f5e90557640bacfe5/tests/sqllogictests/suites/base/06_show/06_0003_show_settings.test

Make sure this PR is works.

BohuTANG
BohuTANG approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for the contribution.

@BohuTANG BohuTANG merged commit a639b33 into databendlabs:main Dec 13, 2023
70 checks passed
@guojidan guojidan deleted the max branch December 13, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@zhang2014 zhang2014 Awaiting requested review from zhang2014

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: set max_storage_io_requests as a big number value causing memory allocation panic
2 participants
@guojidan @BohuTANG