Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bincode api to common/io #13973

Merged
merged 4 commits into from
Dec 11, 2023
Merged

chore: bincode api to common/io #13973

merged 4 commits into from
Dec 11, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Dec 11, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

change bincode api to common/io

  • bump bincode to version = "2.0.0-rc.3"
  • src/query/storages/common/table_meta/Cargo.toml still using 1.3.3 for table format it will remove later @dantengsky
  • bincode ABI is not stable, api breaking changes often, this PR shink them all to bincode_serialize/deserialize

This change is Reviewable

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 11, 2023
@BohuTANG BohuTANG marked this pull request as ready for review December 11, 2023 05:13
@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13973-069c89b

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

cloud cloud

ClickBench Report

@BohuTANG
Copy link
Member Author

No logic changed, let's merge.

@BohuTANG BohuTANG merged commit 35fc8c2 into databendlabs:main Dec 11, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 Awaiting requested review from zhang2014

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump bincode to latest version
1 participant
@BohuTANG