Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change Result to Option to avoid bring error stack #13901

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Dec 2, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

   if parts.partitions.len() == 1 {
            let part = parts.partitions[0].clone();
            if let Ok(part) = StreamTablePart::from_part(&part) {
                parts = part.inner();
                base_block_ids = Some(part.base_block_ids());
            }
        }

if let Ok(part) = StreamTablePart::from_part(&part) { will always bring the error stack each time.

  • Closes #issue

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 2, 2023
@BohuTANG BohuTANG requested a review from zhyass December 2, 2023 07:19
@BohuTANG BohuTANG marked this pull request as ready for review December 2, 2023 07:31
@BohuTANG BohuTANG merged commit 3111235 into databendlabs:main Dec 2, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants