-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: push down sort pipeline to cluster nodes. #13881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
this PR only has small changes that no need to record, like coding styles.
label
Nov 30, 2023
RinChanNOWWW
force-pushed
the
distributed-sort
branch
from
November 30, 2023 12:17
51fa5b0
to
4afeb45
Compare
5 tasks
RinChanNOWWW
force-pushed
the
distributed-sort
branch
from
December 3, 2023 04:24
78bfd81
to
bbad78b
Compare
Wait for #13909 . |
RinChanNOWWW
force-pushed
the
distributed-sort
branch
from
December 4, 2023 10:37
482a5a4
to
75e0dd9
Compare
zhang2014
approved these changes
Dec 5, 2023
sundy-li
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Push down sort pipeline to cluster nodes.
Cluster nodes build the full sort pipeline:
SortPartialTransform -> SortMergeTransform -> MultiSortMergeTransform
.Coordinator node only builds
MultiSortMergeTransform
.P.S. If the
max_threads
of the coordinator is 1, theMultiSortMergeTranform
will degenerate to aSortMergeTransform
.Tracking in #13889
This change is