feat: add downcast_owned_builder #13765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
ariesdevil
force-pushed
the
downcast_builder
branch
3 times, most recently
from
df3a287 to
f9e10ce
Compare
sundy-li
approved these changes
Nov 22, 2023
ariesdevil
force-pushed
the
downcast_builder
branch
from
f9e10ce to
801e59d
Compare
andylokandy
reviewed
Nov 22, 2023
andylokandy
reviewed
Nov 22, 2023
ariesdevil
force-pushed
the
downcast_builder
branch
from
801e59d to
97203ee
Compare
andylokandy
reviewed
Nov 22, 2023
ariesdevil
force-pushed
the
downcast_builder
branch
from
97203ee to
01b1a04
Compare
ariesdevil
force-pushed
the
downcast_builder
branch
from
01b1a04 to
217bcc4
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
add downcast_owned_builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Add
try_upcast_column_builderandtry_downcast_owned_builderfor ValueType, so the types likeNullableTypeandArrayTypecan downcast builder.This change is