Skip to content

fix(query): fix memory leak for http kill query #13599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix(query): fix memory leak for http kill query #13599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf33e1f
fix(query): fix memory leak for http kill query
zhang2014 Nov 6, 2023
1a16af7
Merge branch 'main' into fix/memory_leak
zhang2014 Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/query/service/src/servers/http/v1/http_query_handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ async fn query_cancel_handler(
let http_query_manager = HttpQueryManager::instance();
match http_query_manager.get_query(&query_id).await {
Some(query) => {
query.detach().await;
query.kill().await;
http_query_manager.remove_query(&query_id).await;
StatusCode::OK
Expand Down