-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add table lock manager to fix table lock cannot be released #13434
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
5c6856a
to
9951426
Compare
src/query/storages/fuse/src/operations/mutation/compact/segment_compact_mutator.rs
Outdated
Show resolved
Hide resolved
Docker Image for PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 20 files at r4, 15 of 49 files at r6, 6 of 56 files at r7, 5 of 28 files at r12, 15 of 36 files at r13, 15 of 22 files at r14, 19 of 20 files at r16, 1 of 1 files at r17, all commit messages.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @dantengsky, @soyeric128, @Xuanwo, @zhang2014, and @zhyass)
…tabendlabs#13434) * Add table lock manager * make lint * rename to table lock holder * Add valid check * fix * add metrics * add catalog * add test * fix review comment * remove unused * fix table lock release * add check lock * remove unused codes * update * fix * remove unused code * make lint * Add table lock meta * add setting acquire_lock_timeout_secs * rename metrics * fix * add user in table lock meta * fix comment * fix test * rename * update * remove lockrequest * rename * fix lint * fix review comment * fix test * Update src/meta/proto-conv/tests/it/proto_conv.rs Co-authored-by: Winter Zhang <[email protected]> * fix review comment * add retry for lock holder * update --------- Co-authored-by: Winter Zhang <[email protected]>
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Add table lock manager to fix table lock cannot be released bug.
Add setting
acquire_lock_timeout
to set the maximum timeout in seconds for acquire a lock, the default value is 10 sec.Move
table-lock
out of the ee features.This change is