Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Polish error output for thrift errors #13412

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 24, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Before

Screenshot 2023-10-24 at 13 27 57

After

image


This change is Reviewable

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 6:50am

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 24, 2023
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@PsiACE PsiACE enabled auto-merge October 24, 2023 06:52
@BohuTANG BohuTANG disabled auto-merge October 24, 2023 07:09
@BohuTANG BohuTANG merged commit 49db8d1 into databendlabs:main Oct 24, 2023
60 checks passed
@Xuanwo Xuanwo deleted the debug-catalog branch October 24, 2023 07:44
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants