feat: migrate tracing reporter from jaeger agent to opentelemetry collector (otlp) #13381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
pr-feature
andylokandy
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Docker Image for PR
|
zhang2014
reviewed
Oct 23, 2023
disabled trace for mysql handler unit test in #13389 |
|
#13391 merged, let's continue 🚀 |
|
The unit test is still slow. |
|
seems opentelemetry reporter is blocking the only thread |
Put it in a single thread? The old way is in a spawn thread. |
BohuTANG
added
ci-benchmark
zhang2014
approved these changes
Oct 23, 2023
zhang2014
reviewed
Oct 23, 2023
Docker Image for PR
|
andylokandy
added a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
…lector (otlp) (databendlabs#13381) * feat: migrate tracing from jaeger agent to opentelemetry collector (otlp) * fix * address comment * fix --------- Co-authored-by: BohuTANG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
DATABEND_JAEGER_ENDPOINTis replaced byDATABEND_OTEL_EXPORTER_OTLP_ENDPOINT.This change is