Skip to content

Commit

Permalink
add push down comments
Browse files Browse the repository at this point in the history
  • Loading branch information
JackTan25 committed Oct 4, 2023
1 parent 28da525 commit e205e65
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/query/sql/src/planner/binder/merge_into.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ impl Binder {
self.bind_single_table(bind_context, &source_data).await?;

// add all left source columns for read
// todo: (JackTan25) do column prune after finish "split expr for target and source"
let mut columns_set = left_context.column_set();

let update_columns_star = if self.has_star_clause(&matched_clauses, &unmatched_clauses) {
Expand Down Expand Up @@ -511,4 +510,9 @@ impl Binder {
}
false
}

// target_only_expr rules:
// we need to find all exprs in matched/unmatched clauses' [AND expr].
// split all exprs which is correlated to target table and push down these
// expr to filter data of target table.
}

0 comments on commit e205e65

Please sign in to comment.