show table options when 'show create table.'

databendlabs · Dec 4, 2023 · 5901f5d · 5901f5d
1 parent 507b466
commit 5901f5d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/src/query/service/src/interpreters/interpreter_table_show_create.rs b/src/query/service/src/interpreters/interpreter_table_show_create.rs
@@ -158,7 +158,7 @@ impl ShowCreateTableInterpreter {
             .get_hide_options_in_show_create_table()
             .unwrap_or(false);
 
-        if !hide_options_in_show_create_table {
+        if !hide_options_in_show_create_table || engine == "ICEBERG" {
             table_create_sql.push_str({
                 let mut opts = table_info.options().iter().collect::<Vec<_>>();
                 opts.sort_by_key(|(k, _)| *k);

diff --git a/tests/suites/1_stateful/10_iceberg/10_0002_iceberg_engine.result b/tests/suites/1_stateful/10_iceberg/10_0002_iceberg_engine.result
@@ -8,12 +8,6 @@
 5	e
 6	d
 <<<<
->>>> show create table test_iceberg;
-test_iceberg	CREATE TABLE `test_iceberg` (
-  `id` INT NOT NULL,
-  `data` VARCHAR NOT NULL
-) ENGINE=ICEBERG
-<<<<
 >>>> drop table test_iceberg;
 >>>> drop connection if exists iceberg_conn;
 >>>> create connection iceberg_conn storage_type = 's3' access_key_id ='minioadmin' secret_access_key ='minioadmin' ENDPOINT_URL='http://127.0.0.1:9900';
@@ -30,6 +24,6 @@ test_iceberg	CREATE TABLE `test_iceberg` (
 test_iceberg	CREATE TABLE `test_iceberg` (
   `id` INT NOT NULL,
   `data` VARCHAR NOT NULL
-) ENGINE=ICEBERG
+) ENGINE=ICEBERG CONNECTION_NAME='iceberg_conn' LOCATION='s3://testbucket/iceberg_ctl/iceberg_db/iceberg_tbl/'
 <<<<
 >>>> drop table test_iceberg;
diff --git a/tests/suites/1_stateful/10_iceberg/10_0002_iceberg_engine.sh b/tests/suites/1_stateful/10_iceberg/10_0002_iceberg_engine.sh
@@ -12,8 +12,6 @@ echo "create table test_iceberg engine = iceberg location = 'fs://${ROOT}/';" |
 
 query "select * from test_iceberg order by id, data;"
 
-query "show create table test_iceberg;"
-
 stmt "drop table test_iceberg;"
 
 stmt "drop connection if exists iceberg_conn;"