fix(driver): do not box nullable for null datatype

databendlabs · Apr 27, 2023 · a5612fc · a5612fc
1 parent 3977def
commit a5612fc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/driver/Cargo.toml b/driver/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "databend-driver"
-version = "0.2.20"
+version = "0.2.21"
 edition = "2021"
 license = "Apache-2.0"
 description = "Databend Driver for Rust"

diff --git a/driver/src/schema.rs b/driver/src/schema.rs
@@ -256,7 +256,7 @@ impl TryFrom<&Arc<ArrowField>> for Field {
                 )))
             }
         };
-        if f.is_nullable() {
+        if f.is_nullable() && !matches!(dt, DataType::Null) {
             dt = DataType::Nullable(Box::new(dt));
         }
         Ok(Field {

diff --git a/tests/Makefile b/tests/Makefile
@@ -1,5 +1,7 @@
 default: run
 
+run: test-core test-driver test-bendsql down
+
 prepare:
 	mkdir -p data/databend
 
@@ -19,8 +21,6 @@ test-bendsql: up
 	cd .. && ./cli/test.sh http
 	cd .. && ./cli/test.sh flight
 
-run: test-core test-driver test-bendsql
-
 down:
 	docker compose down