Skip to content

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Dec 15, 2020

Part of #922

Description

Implements submitErrors support for PF4 mapper. (I will add the support for other mappers in a batch as fixes, this is made separately to provide it to our community ASAP)

Schema (if applicable)

onSubmit={() => ({field: 'some error message'})}

submiterror

@rvsia rvsia added enhancement New feature or request PF4 PF4 pull request labels Dec 15, 2020
@rvsia rvsia requested a review from Hyperkid123 December 15, 2020 10:55
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #924 (ca5aa83) into master (ebbc471) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   93.39%   93.40%           
=======================================
  Files         235      235           
  Lines        3695     3699    +4     
  Branches     1222     1225    +3     
=======================================
+ Hits         3451     3455    +4     
  Misses        244      244           
Impacted Files Coverage Δ
...ages/pf4-component-mapper/src/common/form-group.js 100.00% <100.00%> (ø)
...ages/pf4-component-mapper/src/common/show-error.js 100.00% <100.00%> (ø)
...ages/pf4-component-mapper/src/files/field-array.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9616f4...ca5aa83. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit df103ab into data-driven-forms:master Dec 15, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.19.0 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PF4 PF4 pull request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants