Finally get rid of interchange_to_pandas#69
Merged
MarcoGorelli merged 2 commits intodata-apis:mainfrom Jan 24, 2024
Merged
Conversation
anmyachev
force-pushed
the
backend-agnostic-tests
branch
5 times, most recently
from
de7150e to
3db306f
Compare
Contributor
|
I think the diff here on github looks more complicated that it needs to, could you rebase onto |
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
backend-agnostic-tests
branch
from
0a4ad77 to
ea0bf15
Compare
Contributor
Author
Sure, done. |
MarcoGorelli
approved these changes
Jan 24, 2024
Contributor
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
thanks @anmyachev !
Contributor
|
@anmyachev thanks for your PRs, really appreciate them FYI I'd like to do a pretty big refactor / redesign to address data-apis/dataframe-api#346 , so I'd suggest waiting a little in case you wanted to put a lot of effort into a modin version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #66