Use new function for Polars instead of deprecated ones#68
Merged
MarcoGorelli merged 11 commits intodata-apis:mainfrom Jan 23, 2024
Merged
Use new function for Polars instead of deprecated ones#68MarcoGorelli merged 11 commits intodata-apis:mainfrom
MarcoGorelli merged 11 commits intodata-apis:mainfrom
Conversation
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
update-polars
branch
from
b1e3be9 to
65b3ef6
Compare
This reverts commit 65b3ef6.
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
commented
Jan 22, 2024
| ) -> DataFrame: | ||
| return self._from_dataframe( | ||
| self.dataframe.with_columns(pl.col("*").__eq__(other)), | ||
| self.dataframe.with_columns(pl.col("*").__eq__(other)), # type: ignore[operator] |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, I haven't found a way to fix the following errors instead of just ignoring them: dataframe_api_compat/polars_standard/dataframe_object.py:240: error: Unsupported operand types for == ("Expr" and "Union[Union[str, int, float, bool], Scalar]") [operator]
Contributor
Author
|
@MarcoGorelli ready for review |
|
|
||
| def size(self) -> DataFrame: | ||
| result = self._grouped.count().rename({"count": "size"}) | ||
| method = "len" if hasattr(self._grouped, "len") else "count" |
Contributor
There was a problem hiding this comment.
not too keen on hasattr matching, could we either check against the polars version, or just bump up the minimum supported version?
anmyachev
force-pushed
the
update-polars
branch
2 times, most recently
from
a37d7a9 to
5668b44
Compare
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
update-polars
branch
from
5668b44 to
a620d12
Compare
MarcoGorelli
approved these changes
Jan 23, 2024
Contributor
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
thanks @anmyachev !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.