-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: finfo_object
, iinfo_object
, _array
to typing.Protocol
#857
base: main
Are you sure you want to change the base?
Conversation
@34j thanks a lot for working on improving static typing. Did you see gh-589 though? This PR seems to reinvent parts of that PR. It's nontrivial to review a large PR and get static typing right, but I prefer to push gh-589 forward if there is energy for that. Would you be interested in checking if that addresses your issue and needs? |
7175de0
to
ac20ed5
Compare
788ba04
to
f3c9eb4
Compare
@jorenham you may have opinions on the activity here |
I certainly do. But before I share them, would you mind telling me what the exact purpose is of these "stubs" (which usually refer to |
Not sure about the exact purpose, but they aren't (just) type stubs - they're primarily for housing the (sort of typed) signatures and docstrings from which the docs pages for individual functions are generated. I suppose they are "stubs" in the sense of having no function implementations. |
Then I think that the first step should be to figure that out, and document it.
|
Disclaimer: I'm sure the array API maintainers 'know what they are building' - I've contributed to the repo, but not majorly. |
Perhaps the maintainers are mostly interested in discussing the contents of array-api and this may not be so important. However, I have noticed a number of issues while working on this implementation and the #858 implementation, and would like to offer some observations.
Thanks for taking a look anyway |
Closes #856