removed unused servicecontexts #231

[erlendoksvoll]

Description

Removed clutter

Documentation

• Doc updated (automatically)

Summary by CodeRabbit

• Chores
  • Removed Seriøsitetsinformasjon and EURES service integrations from the platform.

[coderabbitai]

Walkthrough

Removed two ServiceContext entries (Seriøsitetsinformasjon and EURES) from service context registration and refactored the DAN-test configuration block to use proper C# collection initialization syntax with corrected braces and commas.

Changes

Cohort / File(s)	Summary
ServiceContext configuration cleanup Dan.Core/Services/ServiceContextService.cs	Removed two service contexts (seriositet-product, eures-product); refactored DAN-test block from non-standard to standard C# collection initializations (ValidLanguages, AuthorizationRequirements as List); adjusted formatting and braces.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify that the removed service contexts (Seriøsitetsinformasjon and EURES) are no longer required elsewhere in the codebase
• Confirm that the refactored DAN-test collection initialization compiles and produces equivalent runtime behavior

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "removed unused servicecontexts #231" is directly related to the primary change in the changeset. According to the raw_summary, the main modifications include removing two ServiceContext entries (Seriøsitetsinformasjon and EURES). The title is concise, specific, and clearly conveys the essential action taken, allowing a teammate to quickly understand the purpose of the change when scanning commit history. While the changeset also includes secondary formatting adjustments to the DAN-test block, the title appropriately focuses on the most significant change, which aligns with the expected behavior for PR titles.
Docstring Coverage	✅ Passed	Docstring coverage is 0.00% which is sufficient. The required threshold is 0.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/remove-unused-servicecontexts

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Dan.Core/Services/ServiceContextService.cs (1)

223-234: C# 12 collection expression syntax is valid; code style consistency is recommended.

The DAN-test block uses C# 12 collection expressions ([] syntax), which is fully supported by the project's .NET 8.0 target framework. The removed ServiceContext entries ("seriositet-product" and "eures-product") have no references elsewhere in the codebase, so removal is safe.

The only consideration is code style consistency: this block uses modern collection expression syntax while other ServiceContext entries use the traditional new List<T>() {} pattern. If consistency across the file is desired, consider aligning to a single style.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2427cd4 and ac97e06.

📒 Files selected for processing (1)

• Dan.Core/Services/ServiceContextService.cs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (csharp)

🔇 Additional comments (1)

Dan.Core/Services/ServiceContextService.cs (1)

11-263: Removed ServiceContext IDs verified as not referenced elsewhere.

Comprehensive search across the codebase confirms that the removed ServiceContext IDs ("seriositet-product" and "eures-product") and their associated names ("Seriøsitetsinformasjon" and "EURES") do not appear in configuration files, tests, documentation, or any other source files. The removal is safe.