-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a tutorial for the Maps module #605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done! Just the one minor comment and then we should be ready to merge and deploy.
docs/tutorial.rst
Outdated
@@ -388,4 +388,48 @@ Let's do the bootstrap test on the two categories. | |||
|
|||
Drawing Maps | |||
------------ | |||
To come. | |||
The main class in the maps module is the Map class. In this code we create a default map. Maps can be displayed or converted to html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"In this code we create a default map" -> "In this code we create a default Map" (to distinguish against Python maps)
Thank you for your feedback. I have changed it from map to Map. |
Just merged! Once again, amazing job on this - looking forward to future contributions :) |
This pull request addresses issue #390 by introducing a tutorial for the maps module. I welcome feedback to enhance the clarity and effectiveness of the tutorial content.