Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a tutorial for the Maps module #605

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

ShuaibNuruddin
Copy link
Contributor

This pull request addresses issue #390 by introducing a tutorial for the maps module. I welcome feedback to enhance the clarity and effectiveness of the tutorial content.

Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done! Just the one minor comment and then we should be ready to merge and deploy.

@@ -388,4 +388,48 @@ Let's do the bootstrap test on the two categories.

Drawing Maps
------------
To come.
The main class in the maps module is the Map class. In this code we create a default map. Maps can be displayed or converted to html.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In this code we create a default map" -> "In this code we create a default Map" (to distinguish against Python maps)

@coveralls
Copy link

coveralls commented Dec 18, 2023

Coverage Status

coverage: 93.535%. remained the same
when pulling 66de3ab on ShuaibNuruddin:master
into 2e0c20d on data-8:master.

@ShuaibNuruddin
Copy link
Contributor Author

Thank you for your feedback. I have changed it from map to Map.

@adnanhemani adnanhemani self-requested a review December 19, 2023 06:16
@adnanhemani adnanhemani merged commit e5a74eb into data-8:master Dec 19, 2023
2 checks passed
@adnanhemani
Copy link
Member

Just merged! Once again, amazing job on this - looking forward to future contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants