Conversation
martinheidegger
left a comment
martinheidegger
left a comment
There was a problem hiding this comment.
I am not sure prettier-standard is overkill.
| return new spectron.Application({ | ||
| path: path.join(__dirname, '../node_modules/.bin/electron'), | ||
| args: [path.join(__dirname, '../index.js'), '--data', TEST_DATA, '--db', TEST_DATA_DB], | ||
| args: [ |
There was a problem hiding this comment.
Is it just me or has this become significantly less readable.
There was a problem hiding this comment.
yes, it's not perfect every single time, but it's consistent
There was a problem hiding this comment.
before, this line was 91 chars long, limiting lines to 80 chars is a common practice
| return waitForLoad(app) | ||
| .then(() => app.browserWindow.isVisible()) | ||
| .then((val) => t.ok(val, 'isVisible')) | ||
| .then(val => t.ok(val, 'isVisible')) |
There was a problem hiding this comment.
Just noticed that the #453 needs to be merge into this.
| }).then(function () { | ||
| return app.client.waitUntilWindowLoaded() | ||
| }) | ||
| return app |
There was a problem hiding this comment.
This also seems way more stringent in the former version.
|
I'm going to make a move on this now because I don't want to have to deal with too many merge conflicts and value having a formatter a lot. The success of prettier and languages like go that have this built on speaks about the advantages. Not having to argue about the best way of writing something ever again, in a collaborative environment, is usually worth more than that one perfect way of writing a code block. |
2 participants
based upon #480, this will help us even more with consistency across all contributors.
Some of prettier's rules can be tweaked as well, but for now I value consistency a lot over the "most optimal way" of writing a line of code.