This repository was archived by the owner on Jan 6, 2022. It is now read-only.
Using new disconnect method to stabilize tests#456
Merged
juliangruber merged 1 commit intomasterfrom Jan 30, 2018
unknown repository
Merged
Using new disconnect method to stabilize tests#456juliangruber merged 1 commit intomasterfrom unknown repository
juliangruber merged 1 commit intomasterfrom
unknown repository
Conversation
martinheidegger
changed the title
Collaborator
Author
|
Uses latest multidat and is ready for merge, awaiting #455 PR |
Collaborator
|
i merged the other PR, can you rebase this please? |
Collaborator
Author
|
Rebased |
Collaborator
|
Thank you, Martin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
.disconnectmethod in dat-ecosystem-archive/multidat#12 and dat-ecosystem-archive/multidrive#14 allows to write more stable tests and should leave less connections in limbo if used properly on app shutdown.Since both references PR's are not yet merged this PR is marked[WIP]