Skip to content

Polish Fine Performance Metrics bokeh plot #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2023
Merged

Polish Fine Performance Metrics bokeh plot #7963

merged 1 commit into from
Jul 5, 2023

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jul 4, 2023 •
edited
Loading

  • hide activities from the legend of each plot when they don't actually appear in it. Notably, hide the "network" activity in the task execution plots.
  • in the pie charts, sort both the pie slices and the legend from biggest to smallest activity, substantially improving readability (the biggest activities always appear at the top of the legend)
    image

@crusaderky crusaderky requested a review from fjetter as a code owner July 4, 2023 17:45
@crusaderky crusaderky requested a review from milesgranger July 4, 2023 17:46
@crusaderky crusaderky self-assigned this Jul 4, 2023
@crusaderky crusaderky mentioned this pull request Jul 4, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±0         20 suites  ±0   11h 39m 9s ⏱️ + 36m 32s
  3 700 tests ±0    3 590 ✔️  - 1     106 💤 ±0  4 ❌ +1 
35 786 runs  ±0  34 033 ✔️  - 2  1 749 💤 +1  4 ❌ +1 

For more details on these failures, see this check.

Results for commit ac9bc2b. ± Comparison against base commit c6f451a.

@hendrikmakait hendrikmakait self-requested a review July 5, 2023 07:28
hendrikmakait
hendrikmakait approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crusaderky, this really improves readability of the charts!

@hendrikmakait hendrikmakait merged commit fca4b35 into dask:main Jul 5, 2023
@crusaderky crusaderky deleted the bokeh_cleanup branch July 5, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

@milesgranger milesgranger Awaiting requested review from milesgranger

Assignees

@crusaderky crusaderky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crusaderky @hendrikmakait