-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client.upload_file
send to both Workers and Scheduler
#7802
Client.upload_file
send to both Workers and Scheduler
#7802
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files ± 0 26 suites ±0 16h 7m 41s ⏱️ + 57m 33s For more details on these failures, see this check. Results for commit 830f4e0. ± Comparison against base commit 57ae3e7. ♻️ This comment has been updated with latest results. |
c8718af
to
337029a
Compare
preloads before getting scheduler address
a559af1
to
9ec280e
Compare
@jrbourbeau this is ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milesgranger! This is looking good
The current main
branch has upload_file
related breakages, but no test coverage to account for those breakages. Is this something you could add here?
When you have time @jrbourbeau I think this is ready for a final look. |
@jacobtomlinson I think James is out most of this week, would you be able to give this another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thanks @milesgranger. It looks like you've addressed everything. If there is anything else from @jrbourbeau I'm sure we can address it in a follow up.
I might put out a warning tweet about renaming the temporary directly but other than that this should have minimal impact.
…ratch directory (dask#7802)
Closes #7797
Tests added / passed
Passes
pre-commit run --all-files
Moves the previous
Worker.upload_file
intoServer.upload_file
, giving access to both workers and the scheduler to alocal_directory
.Impl of
UploadFile
for theScheduler
Updates
Client.upload_file
to upload files to both scheduler and workers.