-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster wait #6700
Merged
Merged
Cluster wait #6700
Changes from 39 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
4f850e8
Moving wait_for_worker logic to cluster, and having client call that …
idorrington92 ec66806
Merge branch 'main' of https://github.com/dask/distributed into clust…
idorrington92 4ee2739
Adding test for cluster.wait_for_workers
idorrington92 f9a840b
use try and except to catch case where cluster is none or wait_for_wo…
idorrington92 5439674
Merge branch 'main' into cluster_wait
idorrington92 ca778c7
linting
idorrington92 8f532e9
Merge remote-tracking branch 'upstream/main' into cluster_wait
idorrington92 78985cc
This test has been removed on main branch, but for some reason git me…
idorrington92 aad5d56
Cluster has to use scheduler_info attribute instead of scheduler.iden…
idorrington92 b1ad4d5
Merge remote-tracking branch 'upstream/main' into cluster_wait
idorrington92 ef96549
lint
idorrington92 e682058
reverting
idorrington92 cdf2c0b
Merge remote-tracking branch 'upstream/main' into cluster_wait
idorrington92 45cf486
need to use cluster.scale when client.wait_for_workers is called whil…
idorrington92 088e696
need to use scheduler_info. Also, using cluster.scale to emulate beha…
idorrington92 4861151
using scheduler_info and dont need to call scale anymore
idorrington92 1d9705c
lint
idorrington92 97f4aa4
Merge remote-tracking branch 'upstream/main' into cluster_wait
idorrington92 c3907b7
adding gen_test decorator
idorrington92 ac1dbc5
Don't think we need to scale at start of wait_for_workers
idorrington92 44ccdd3
self.scheduler_info does not update worker status from init to runnin…
idorrington92 b78772e
Use Status
idorrington92 05eb270
Merge remote-tracking branch 'upstream/main' into cluster_wait
idorrington92 03d9d18
Scale was fixing the nworkers test because it forced the worker statu…
idorrington92 dfa0ea0
Refactoring
idorrington92 3d8ddca
Fixing type information
idorrington92 625960d
Experimenting with creating new comm
idorrington92 c946540
Create separate comm in _start and use that to update scheduler_info
idorrington92 7af5fce
Close new comm
idorrington92 2dd7932
initialise scheduler_info_comm
idorrington92 872e62a
Merge remote-tracking branch 'upstream/main' into cluster_wait
idorrington92 05a54c7
Don't allow n_workers to be zero for cluster wait_for_workers
idorrington92 632cfa9
Adding return type
idorrington92 5789bfd
Merge branch 'main' of https://github.com/dask/distributed into clust…
idorrington92 000febc
Change try-catch to be an explicit if-else
idorrington92 3d573e5
Check explicitly for cluster is none, as I think it's clearer
idorrington92 2b1713a
linting
idorrington92 8877a58
use scheduler_comm instead of opening new comm
idorrington92 005dd69
remove update_scheduler_info method
idorrington92 db9dc71
Merge branch 'main' of https://github.com/dask/distributed into clust…
idorrington92 494d3fc
pre-commit changes
idorrington92 21277ce
Merge branch 'main' of https://github.com/dask/distributed into clust…
idorrington92 d277ea6
Reduce number of works to see if it fixes github tests
idorrington92 c95aafd
Changing test to make it work in python 3.8
idorrington92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing unions with a pipe like this is supported in Python >=3.10. Not sure if that's related to the issues we are seeing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed it's 3.8. I do get same error locally. Changing (or removing) type hints doesn't fix it.
It's a thread leaking issue, which sounds much lower level that anything I've done here, but I'll keep looking in to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've managed to fix it. I noticed the other tests in test_cluster used "async with" to start the cluster, and didn't pass in the loop fixture, so I copied that. I'd be lying if I said I knew what went wrong and how this fixed it though...