Skip to content

Make spec repr generic #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrocklin merged 3 commits into from
Jul 15, 2019
Merged

Make spec repr generic #2834

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1ef901
Make spec repr generic
jacobtomlinson Jul 12, 2019
70775ad
Add repr test
jacobtomlinson Jul 15, 2019
9cf2204
Remove bad copypasta
jacobtomlinson Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion distributed/deploy/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,8 @@ async def scale_down(self, workers):
scale_up = scale # backwards compatibility

def __repr__(self):
return "SpecCluster(%r, workers=%d)" % (
return "%s(%r, workers=%d)" % (
type(self).__name__,
self.scheduler_address,
len(self.workers),
)
Expand Down
9 changes: 9 additions & 0 deletions distributed/deploy/tests/test_spec_cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ def test_loop_started():
)


@pytest.mark.asyncio
async def test_repr():
class MyCluster(SpecCluster):
pass

async with MyCluster(..., asynchronous=True) as cluster:
Comment thread
jacobtomlinson marked this conversation as resolved.
Outdated
assert "MyCluster" in str(cluster)


@pytest.mark.asyncio
async def test_scale():
worker = {"cls": Worker, "options": {"nthreads": 1}}
Expand Down