Skip to content

Respect security configuration (#2815) - #2822

Merged
mrocklin merged 4 commits into
dask:masterfrom
rbubley:patch-13
Jul 10, 2019
Merged

Respect security configuration (#2815)#2822
mrocklin merged 4 commits into
dask:masterfrom
rbubley:patch-13

Conversation

@rbubley

@rbubley rbubley commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@mrocklin

mrocklin commented Jul 2, 2019

Copy link
Copy Markdown
Member

cc @jcrist

@mrocklin

mrocklin commented Jul 5, 2019

Copy link
Copy Markdown
Member

Thanks for this fix @rbubley ! If it's ok with you I'd prefer to wait for @jcrist to take a look at this, but I suspect that he's off until next week due to the American holiday.

@jcrist jcrist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay here, was off on vacation. One small fix, and the rest looks good to me. Thanks @rbubley.

Comment thread distributed/deploy/local.py Outdated
elif security:
elif (
security
and security.get_connection_args("scheduler")["require_encryption"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

elif security and security.require_encryption:

@mrocklin
mrocklin merged commit 21370fa into dask:master Jul 10, 2019
@mrocklin

Copy link
Copy Markdown
Member

This is in! Thanks @rbubley for the fix and @jcrist for the review.

muammar added a commit to muammar/distributed that referenced this pull request Jul 18, 2019
* upstream/master: (33 commits)
  SpecCluster: move init logic into start (dask#2850)
  Dont reuse closed worker in get_worker (dask#2841)
  Add alternative SSHCluster implementation (dask#2827)
  Extend prometheus metrics endpoint (dask#2792) (dask#2833)
  Include type name in SpecCluster repr (dask#2834)
  Don't make False add-keys report to scheduler (dask#2421)
  Add Nanny to worker docs (dask#2826)
  Respect security configuration in LocalCluster (dask#2822)
  bump version to 2.1.0
  Fix typo that prevented error message (dask#2825)
  Remove dask-mpi (dask#2824)
  Updates to use update_graph in task journey docs (dask#2821)
  Fix Client repr with memory_info=None (dask#2816)
  Fix case where key, rather than TaskState, could end up in ts.waiting_on (dask#2819)
  Use Keyword-only arguments (dask#2814)
  Relax check for worker references in cluster context manager (dask#2813)
  Add HTTPS support for the dashboard (dask#2812)
  CLN: Use dask.utils.format_bytes (dask#2810)
  bump version to 2.0.1
  Add python_requires entry to setup.py (dask#2807)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants