Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure all references #2

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Secure all references #2

merged 1 commit into from
Mar 29, 2019

Conversation

fuglede
Copy link
Contributor

@fuglede fuglede commented Mar 29, 2019

This is part PR, part question.

First of all, we secure all references to docs.dask.org and ml.dask.org, changing http to https in the cases where https wasn't already used.

I went through various randomly picked parts of https://docs.dask.org to make sure that this wouldn't cause any issues with mixed content and everything seems alright. I do wonder, though, if there's then any reason why the various dask.org subdomains do not automatically redirect to https like dask.org itself does?

@mrocklin
Copy link
Member

First of all, we secure all references to docs.dask.org and ml.dask.org, changing http to https in the cases where https wasn't already used.

Thanks!

I do wonder, though, if there's then any reason why the various dask.org subdomains do not automatically redirect to https like dask.org itself does?

Probably just ignorance. @aterrel do you know the best way to do this?

@mrocklin mrocklin merged commit 197ff92 into dask:master Mar 29, 2019
@fuglede
Copy link
Contributor Author

fuglede commented Mar 29, 2019

Looked into it a tiny bit more (not being familiar with Read the Docs myself), and it looks like automatic redirection is not actually supported (but is a common request): readthedocs/readthedocs.org#4641 -- too bad.

@fuglede
Copy link
Contributor Author

fuglede commented Mar 30, 2019

FYI (and hope you don't mind): I ended up writing an HTTPS Everywhere ruleset -- EFForg/https-everywhere#17647 -- this way users of that browser add-on will be able to take advantage of the fact that all the pages are securable. This will then be mostly redundant if the readthedocs request is ever closed and you set up automatic redirects.

@aterrel
Copy link

aterrel commented Mar 30, 2019

I recommend making all references in your docs go to “//foo.dask.org” which I believe is the syntax in html for keeping the same protocol as the host url.

One can create a page rule in cloudflare, but you only get 3 and then it’s $5 a month for 5 rules.

So at the point you need 10 rules cheaper to just manage your own ngnix host on ec2.

@fuglede
Copy link
Contributor Author

fuglede commented Mar 30, 2019 via email

@mrocklin
Copy link
Member

Ping @aterrel

Also, I'd be happy to pay the $5/month to have dask be https by default everywhere without having to manage a box on ec2.

@aterrel
Copy link

aterrel commented Apr 10, 2019

@fuglede Cloudflare-managed certs are automatically created by Cloudflare not Read The Docs. Cloudflare then terminates the ssl connection and forwards http connection to ReadTheDocs.

Cloudflare allows you to modify any redirect rules you like.

@aterrel
Copy link

aterrel commented Apr 10, 2019

Let me know who wants to manage your cloudflare account and I can add you.

@aterrel
Copy link

aterrel commented Apr 10, 2019

Well it looks like I was thinking about other things on cloudflare. For docs.dask.org it only acts as an alias so https is entirely managed by readthedocs.

Screen Shot 2019-04-10 at 8 10 23 AM

@aterrel
Copy link

aterrel commented Apr 10, 2019

so seems like I still have to set up redirects on cloudflare, as the RTD custom domain https doesn't do them.

readthedocs/readthedocs.org#2652 (comment)

@aterrel
Copy link

aterrel commented Apr 10, 2019

I also added a redirect rule for docs.dask.org will wait to see if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants