Add fix for downloading config files from GitHub #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
commented
Nov 14, 2024
| url, | ||
| headers={"User-Agent": f"Dask sphinx theme {dask_sphinx_theme.__version__}"}, | ||
| ) | ||
| r.raise_for_status() |
There was a problem hiding this comment.
Note that this line isn't actually needed, but makes debugging things much easier. Right now we get a weird yaml parsing error instead of an HTTP error.
phofl
approved these changes
Nov 14, 2024
|
Okay, I'm going to merge this to unblock docs build. @jacobtomlinson I'm happy to handle any comments you may have in a follow up PR though |
5 tasks
4 tasks
|
Thanks for handling this @jrbourbeau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full context is here dask/dask#11522
It looks like GitHub started blocking us downloading Dask config files for some reason. Stackoverflow recommended setting a custom
User-Agent, which I've confirmed fixes things (at least for now -- again not sure what changed on the GitHub side. I can open a support ticket).cc @jacobtomlinson @phofl