New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New collection classes are not registered with `get_parallel_type` yet #985

Open

rjzamora opened this issue Mar 18, 2024 · 0 comments

Labels

bug

Member

rjzamora commented Mar 18, 2024

Minor inconsistency between the new and legacy API:

from dask.dataframe.core import has_parallel_type

assert has_parallel_type(<legacy collection>)  # Passes
assert has_parallel_type(<new expr-based collection>)  # Fails

rjzamora added the bug label

rjzamora mentioned this issue

Relax type-check in test_proxy.py rapidsai/dask-cuda#1321

Merged

rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this issue


          Relax type-check in test_proxy.py (#1321)

62c27d5

There is a minor [missing feature in dask-expr](dask/dask-expr#985). I suggest we relax this test a bit to handle both "legacy" and "new" DataFrame collections.

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #1321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment