Skip to content

Conversation

@charlesbluca
Copy link
Member

Noticed that the examples page hadn't been bumped to the new theme yet; think it's because the dask-sphinx-theme version isn't being quote-escaped in the mamba install command; this PR resolves this.

Will also scan through to see if there are any other places where this is happening.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlesbluca! This change seems harmless, though I wonder why we need quotes now as before #221 we didn't need quotes. Maybe because of the .?

Would you mind adding a extra step with this code so we can see what's installed in the testing environment? We do this in other project's CI builds to help with debugging these types of situations.

@charlesbluca
Copy link
Member Author

charlesbluca commented Jun 6, 2022

we need quotes now as before #221 we didn't need quotes

it looks like this has been an issue before #221 - looking at the logs of earlier runs the mamba command was affected in the same way. Still, I'm interested in why the interpreted install (i.e. mamba install dask-sphinx-theme) didn't go for 3.0.0 if that was the latest version.

Would you mind adding a extra step

Sure, I can add that after the mamba install

@jrbourbeau jrbourbeau merged commit 65d6ac2 into dask:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants