[DF] Enable some distinct agg tests #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Sep 21, 2022
| let alias = format!("__dask_sql_count__{}", optimizer_config.next_id()); | ||
| let aggr_expr = vec![count(Expr::Literal(ScalarValue::UInt64(Some(1)))).alias(&alias)]; | ||
| let expr_name = expr.name()?; | ||
| let count_expr = Expr::Column(Column::from_qualified_name(&expr_name)); |
Contributor
Author
There was a problem hiding this comment.
This is the main fix - COUNT(col) instead of COUNT(1)
andygrove
changed the title
andygrove
requested review from
ayushdg,
charlesbluca,
galipremsagar and
jdye64
as code owners
| a = make_rand_df( | ||
| 100, a=(int, 50), b=(str, 50), c=(int, 30), d=(str, 40), e=(float, 40) | ||
| ) | ||
| # note that this test repeats the expression `COUNT(DISTINCT a)` |
Collaborator
There was a problem hiding this comment.
Do we want to open an issue to follow up on the dupe case later on?
charlesbluca
approved these changes
Sep 21, 2022
Collaborator
charlesbluca
left a comment
charlesbluca
left a comment
There was a problem hiding this comment.
LGTM, thanks @andygrove 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #784