-
Notifications
You must be signed in to change notification settings - Fork 72
Add step argument to get_window_bounds for pandas>=1.5 #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step argument to get_window_bounds for pandas>=1.5 #774
Conversation
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
==========================================
+ Coverage 88.43% 88.59% +0.16%
==========================================
Files 69 69
Lines 3510 3517 +7
Branches 710 711 +1
==========================================
+ Hits 3104 3116 +12
+ Misses 318 309 -9
- Partials 88 92 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ayushdg 🙂 minor comment around the Docker cluster configs, otherwise LGTM
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the latest build of openjdk changed the location of JAVA_HOME, which has in turn broken our Windows testing + one JVM sanity test on Linux; going to go ahead and merge this in for now so we can get the pandas-specific fixes into the datafusion branch, then follow up on the JDK breakage later.
With pandas 1.5 the
get_window_boundsmethod ofbaseIndexeradded astepargument which was causing failing tests during the pandas signature inspection. This pr fixes that by added the arg for pandas>=1.5