Skip to content

Conversation

@ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented Sep 20, 2022

With pandas 1.5 the get_window_bounds method of baseIndexer added a step argument which was causing failing tests during the pandas signature inspection. This pr fixes that by added the arg for pandas>=1.5

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #774 (aaaea07) into main (bab3fa7) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head aaaea07 differs from pull request most recent head ae0ed47. Consider uploading reports for the commit ae0ed47 to get more accurate results

@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   88.43%   88.59%   +0.16%     
==========================================
  Files          69       69              
  Lines        3510     3517       +7     
  Branches      710      711       +1     
==========================================
+ Hits         3104     3116      +12     
+ Misses        318      309       -9     
- Partials       88       92       +4     
Impacted Files Coverage Δ
dask_sql/_compat.py 100.00% <100.00%> (ø)
dask_sql/physical/rel/logical/window.py 98.87% <100.00%> (+0.03%) ⬆️
dask_sql/_version.py 34.00% <0.00%> (+1.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayushdg 🙂 minor comment around the Docker cluster configs, otherwise LGTM

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the latest build of openjdk changed the location of JAVA_HOME, which has in turn broken our Windows testing + one JVM sanity test on Linux; going to go ahead and merge this in for now so we can get the pandas-specific fixes into the datafusion branch, then follow up on the JDK breakage later.

@charlesbluca charlesbluca merged commit 8aa3c64 into dask-contrib:main Sep 20, 2022
@ayushdg ayushdg deleted the bug-pandas-window-indexer branch December 12, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants