[DF] Upgrade pyo and change some signatures to use &str instead of String
#762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
requested review from
ayushdg,
galipremsagar and
jdye64
as code owners
andygrove
changed the title
&str instead of String&str instead of String
andygrove
changed the title
&str instead of String&str instead of String
ayushdg
approved these changes
Sep 14, 2022
charlesbluca
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, there was a new Clippy lint that caused us to change some signatures to use
Stringinstead of&strdue to the lint being incompatible with Pyo. Pyo 0.17.1 resolves this so this PR upgrades to that version and changes some signatures fromStringto&str.