Add max version constraint for fugue

[charlesbluca]

It looks like the recent release of Fugue 0.7.0 has bumped its qpd dependency to a version that only has python support up to 3.8. I'm not sure if this is the cause for the recent Fugue-related failures, but it does mean that at least for now, we should constrain to fugue<0.7.0, where 3.9+ support is guaranteed.

In the long run, we should probably see what the blockers are to allowing 3.9+ support on qpd again, cc @goodwanghan in case you have any additional context to provide here.

[goodwanghan]

Hi, I apologize for the inconvenience, the qpd constraint should not exist. How about I make the change on the QPD side so that you don't need this PR?

[charlesbluca]

@goodwanghan that would be great! I'm not 100% sure if that's the cause of the failures we've been seeing in CI, but resolving that would certainly narrow things down a lot 🙂

[charlesbluca]

It looks like the failures here persist even with the pip package of qpd=0.3.1 (which doesn't have the python<3.9 constraint) 😕 so think for now we might want to go ahead and merge this in to unblock tests, and follow up later with a resolution for whatever the underlying issue is.

[ayushdg]

It looks like the failures here persist even with the pip package of qpd=0.3.1 (which doesn't have the python<3.9 constraint) 😕 so think for now we might want to go ahead and merge this in to unblock tests, and follow up later with a resolution for whatever the underlying issue is.

I see so the issue isn't necessarily qpd and python 3.9+ related but still shows up only on python 3.9 and above right?

[goodwanghan]

I think the problem is on qpd,

 classifiers=[
        # "3 - Alpha", "4 - Beta" or "5 - Production/Stable"
        "Development Status :: 3 - Alpha",
        "Intended Audience :: Developers",
        "Topic :: Software Development :: Libraries :: Python Modules",
        "License :: OSI Approved :: Apache Software License",
        "Programming Language :: Python :: 3.6",
        "Programming Language :: Python :: 3.7",
        "Programming Language :: Python :: 3.8",
        "Programming Language :: Python :: 3 :: Only",
    ],

I will go ahead adding the versions and publish 0.3.2 to unblock you guys

[goodwanghan]

I just published qpd 0.3.2 can you bump up the version to see if that works for you?

[charlesbluca]

so the issue isn't necessarily qpd and python 3.9+ related but still shows up only on python 3.9 and above right?

@ayushdg yeah the issue doesn't seem to be tied to qpd, seems like a larger issue with fugue 0.7.0; for clarity this problem also impacts python 3.8, but we don't see those failures in our CI because our 3.8 testing is pinned to our minimum dependencies (#555) and doesn't pick up the latest fugue package.

I just published qpd 0.3.2 can you bump up the version to see if that works for you?

@goodwanghan looks like you published a new package to PyPI, but the problem here is with the package on conda-forge; to illustrate, looking at qpd 0.3.1 on PyPI, we can see that the python_requires is >=3.6, while the conda-forge recipe for 0.3.1 specifies python>=3.6,<3.9. We'll need to bump the recipe there and publish the new conda package to get those changes reflected here.

In either case, I tried running the tests on python 3.8 with fugue 0.7.0 and the conda package of qpd 0.3.1 and still ran into the same failures, so I think things here will still be broken once the new package is published; I'm happy to dig into this a little more over the next few days, but think a quick fix to at least unblock things in CI is to constrain to older fugue versions for now.

[ayushdg]

Minor suggestion but lgtm!

[codecov-commenter]

Codecov Report

Merging #639 (c66a095) into main (0db4506) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   88.45%   88.60%   +0.14%     
==========================================
  Files          69       69              
  Lines        3500     3500              
  Branches      707      707              
==========================================
+ Hits         3096     3101       +5     
+ Misses        317      308       -9     
- Partials       87       91       +4     

Impacted Files	Coverage Δ
dask_sql/_version.py	34.00% <0.00%> (+1.44%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more