Skip to content

Conversation

@jdye64
Copy link
Collaborator

@jdye64 jdye64 commented Jul 15, 2022

Closes #627

@jdye64 jdye64 added documentation Improvements or additions to documentation datafusion Related to work in DataFusion labels Jul 15, 2022
@jdye64 jdye64 self-assigned this Jul 15, 2022
@ayushdg
Copy link
Collaborator

ayushdg commented Jul 15, 2022

cc: @charlesbluca Curious to know if you have opinions on this and if you have a preference for where these files should live and how many we should maintain

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (datafusion-sql-planner@f87aa36). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             datafusion-sql-planner     #630   +/-   ##
=========================================================
  Coverage                          ?   62.07%           
=========================================================
  Files                             ?       73           
  Lines                             ?     3615           
  Branches                          ?      737           
=========================================================
  Hits                              ?     2244           
  Misses                            ?     1221           
  Partials                          ?      150           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping @ayushdg!

My preference here would be to have:

  • a single environment file matching up with the gpuCI testing PYTHON_VER
  • for this file to reside within continuous_integration/gpuci/
  • potentially for this file to contain only the extra packages installed in this step of the Dockerfile

I'd ideally like this file to make it so we can easily recreate the gpuCI testing environment, which is done by creating the environment created by environment-{PYTHON_VER}-jdk11-dev.yaml and then installing the gpuCI requirements on top of this environment. In this case, we'd achieve this with something like:

conda env create -f continuous_integration/environment-$PYTHON_VER-jdk11-dev.yaml
conda env update -n dask-sql -f continuous_integration/gpuci/environment.yaml

I also think that keeping this file in the gpuCI folder would remove ambiguity on its intended purpose.

As an aside, I think that having the gpuCI requirements specified within the repo is a great way to make the contents of the gpuCI environment more transparent! It might be worthwhile to see if we can find a way to pull these requirements in from the repo during the image builds, which would make it a lot clearer how to bump packages in the gpuCI images (thinking of #614). But would probably like for something like that to be a Dask-wide change, so can hold off on that for now.

Comment on lines +45 to +48
- cudatoolkit=11.5
- cudf=22.06
- dask-cudf
- dask-cuda
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdye64
Copy link
Collaborator Author

jdye64 commented Aug 11, 2022

This has been handled with another PR

@jdye64 jdye64 closed this Aug 11, 2022
@jdye64 jdye64 deleted the conda-gpu-env branch March 16, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

datafusion Related to work in DataFusion documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants