Fix memory issues in Docker builds #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1219 +/- ##
==========================================
- Coverage 81.58% 81.49% -0.09%
==========================================
Files 78 78
Lines 4610 4610
Branches 854 854
==========================================
- Hits 3761 3757 -4
+ Misses 660 659 -1
- Partials 189 194 +5 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ayushdg
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like since merging #1181, we've been encountering some memory/resource pressure during our Docker builds that causes the GHA runs to cancel prematurely:
https://github.com/dask-contrib/dask-sql/actions/runs/5894517992/job/15988310016
Interested in if switching our installation process over to
maturin developand/or limiting the amount of CPUs being used for compilation could resolve things here