Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable case <expr> when syntax #1148

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

ChrisJar
Copy link
Collaborator

Ex: case a when 0 then NULL which is equivalent to case when a=0 then NULL

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #1148 (99b815f) into main (7888493) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   81.30%   81.42%   +0.11%     
==========================================
  Files          78       78              
  Lines        4414     4414              
  Branches      799      799              
==========================================
+ Hits         3589     3594       +5     
+ Misses        649      640       -9     
- Partials      176      180       +4     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisJar ChrisJar marked this pull request as ready for review May 16, 2023 19:04
@ayushdg
Copy link
Collaborator

ayushdg commented May 25, 2023

cc: @jdye64

Copy link
Collaborator

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic makes sense to me. Thanks for adding this @ChrisJar. Is there an issue for this? I ask because I likely will need to implement this in Arrow DataFusion Python later as well or this logic might accidentally be removed.

@jdye64
Copy link
Collaborator

jdye64 commented May 25, 2023

FYI - Made PR to mimic this behavior in Arrow DataFusion Python apache/datafusion-python#388

@charlesbluca charlesbluca merged commit 830787e into dask-contrib:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants