Skip to content

fix(key-wallet): accept non-English BIP-39 mnemonics on all parse paths - #980

Merged
xdustinface merged 3 commits into
devfrom
fix/mnemonic-any-language
Aug 22, 2026
Merged

fix(key-wallet): accept non-English BIP-39 mnemonics on all parse paths#980
xdustinface merged 3 commits into
devfrom
fix/mnemonic-any-language

test(key-wallet-manager): cover mainnet and testnet in non-English mn…

e5fe8b9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 22, 2026 in 0s

76.87% (+0.01%) compared to 1a6fb3b

View this Pull Request on Codecov

76.87% (+0.01%) compared to 1a6fb3b

Details

Codecov Report

❌ Patch coverage is 83.33333% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.87%. Comparing base (1a6fb3b) to head (e5fe8b9).

Files with missing lines Patch % Lines
key-wallet-ffi/src/account_derivation.rs 0.00% 12 Missing ⚠️
key-wallet-ffi/src/mnemonic.rs 42.85% 4 Missing ⚠️
key-wallet/src/mnemonic.rs 97.82% 2 Missing ⚠️
key-wallet-ffi/src/wallet.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #980      +/-   ##
==========================================
+ Coverage   76.86%   76.87%   +0.01%     
==========================================
  Files         329      329              
  Lines       82827    82897      +70     
==========================================
+ Hits        63661    63727      +66     
- Misses      19166    19170       +4     
Files with missing lines Coverage Δ
key-wallet-manager/src/lib.rs 73.47% <100.00%> (ø)
key-wallet-ffi/src/wallet.rs 14.01% <0.00%> (-3.04%) ⬇️
key-wallet/src/mnemonic.rs 98.44% <97.82%> (+1.26%) ⬆️
key-wallet-ffi/src/mnemonic.rs 46.45% <42.85%> (-6.41%) ⬇️
key-wallet-ffi/src/account_derivation.rs 6.16% <0.00%> (-12.56%) ⬇️

... and 20 files with indirect coverage changes