fix(spv): fix shutdown deadlock and ordering

dash-spv/CLAUDE.md

@@ -168,6 +168,9 @@ Use domain-specific error types:
 - **Built on**: `dashcore` library with Dash-specific features enabled
 - **Async runtime**: Tokio with full feature set
 
+### Logging Convention
+The project uses the `tracing` framework for structured logging. New code should use `tracing::` macros (`tracing::info!`, `tracing::debug!`, `tracing::warn!`, `tracing::error!`).
+
 ## Key Implementation Details
 
 ### Storage Architecture

dash-spv/src/client/lifecycle.rs

@@ -193,6 +193,12 @@ impl<W: WalletInterface, N: NetworkManager, S: StorageManager> DashSpvClient<W,
             }
         }
 
+        // Shut down sync coordinator: signals cancellation and waits for manager
+        // tasks to drain before we tear down the network and storage layers.
+        if let Err(e) = self.sync_coordinator.shutdown().await {
+            tracing::warn!("Error shutting down sync coordinator: {}", e);
+        }
+
         // Disconnect from network
         self.network.disconnect().await?;
 

dash-spv/src/error.rs

@@ -210,7 +210,11 @@ pub enum SyncError {
     #[error("Timeout error: {0}")]
     Timeout(String),
 
-    /// Network-related errors (e.g., connection failures, protocol errors)
+    /// Network-related errors (e.g., connection failures, protocol errors).
+    ///
+    /// When returned from a `SyncManager` method, the default `run()` loop
+    /// resets the manager to `WaitingForConnections` and applies a cooldown
+    /// to prevent log/event flooding.
     #[error("Network error: {0}")]
     Network(String),