Skip to content

build(dashmate): remove MacOs malicious software warning - #977

Merged
shuplenkov merged 1 commit into
v0.24-devfrom
feat/macos_notarizing
Apr 26, 2023
Merged

build(dashmate): remove MacOs malicious software warning#977
shuplenkov merged 1 commit into
v0.24-devfrom
feat/macos_notarizing

Conversation

@shuplenkov

@shuplenkov shuplenkov commented Apr 25, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

When you try to install Dashmate MacOs installer, you'll see malicious software warning. To remove this warning we must notarize our application

What was done?

Added an additional notarization step to github actions

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Apr 25, 2023
@shuplenkov shuplenkov changed the title build(dashmate): notarize dashmate MacOs installer build(dashmate): remove MacOs malicious software warning Apr 25, 2023
@shuplenkov
shuplenkov marked this pull request as ready for review April 26, 2023 14:38
@shuplenkov
shuplenkov requested a review from antouhou as a code owner April 26, 2023 14:38
@shuplenkov
shuplenkov merged commit e12ae6a into v0.24-dev Apr 26, 2023
@shuplenkov
shuplenkov deleted the feat/macos_notarizing branch April 26, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants