fix(dashmate): connect ENOENT /var/run/docker.sock - #967
Merged
Conversation
shumkov
requested changes
Apr 24, 2023
shuplenkov
changed the title
shumkov
changed the title
markin-io
pushed a commit
that referenced
this pull request
Apr 28, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
If docker uses non-default context (e.g. in docker-desktop for linux), dashmate throws fatal error:
connect ENOENT /var/run/docker.sockWhat was done?
Now at the start, we are trying to find out from the docker its current socket path and use it instead of the default one.
How Has This Been Tested?
Manual
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only