test(dapi-client): fix broken SimplifiedMasternodeListDAPIAddressProvider test - #916
Merged
Conversation
markin-io
pushed a commit
that referenced
this pull request
Apr 26, 2023
5 tasks
markin-io
pushed a commit
that referenced
this pull request
Apr 26, 2023
bfoss765
added a commit
to bfoss765/platform
that referenced
this pull request
Aug 1, 2026
All eight workspace rust-dashcore dependencies were redirected at bfoss765/rust-dashcore solely to pick up `MasternodeList::masternodes_by_voting_key`. That revision also carried ~528 lines of unrelated owner-tagged-reservation and asset-lock behaviour, and the upstream PR carrying the helper (dashpay/rust-dashcore#916) is CHANGES_REQUESTED, conflicting against dev, and has been asked to split — so the pin had no bounded lifetime. Revert the pin to the Dash-owned revision v4.2-dev already tracks (70d4bf8e36057c58e02d56769a6e9760f701dd06) and implement the filter locally in `spv/runtime.rs` as a private free function over the engine's current-tip MasternodeList. It reads only long-standing public SML fields (`key_id_voting`, `pro_reg_tx_hash`, both present on that revision), and folds in the `ProTxHash -> [u8; 32]` internal-byte-order conversion the caller previously did itself, so `masternodes_by_voting_key_blocking` gets shorter rather than longer. Four unit tests cover multi-match, single-match, no-match and the empty-list case. Swapping back to the upstream helper once dashpay#916 lands is tracked by dashpay#4262, cited in a doc comment at the duplication site. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bfoss765
added a commit
to bfoss765/platform
that referenced
this pull request
Aug 5, 2026
…ged reservation API Point all rust-dashcore workspace crates at dashpay/rust-dashcore 8f78baa6b7979b9bea56501ad75b5a7b7150a711, the dev merge commit of PR dashpay/rust-dashcore#916, which lands the additive owner-tagged reservation API this PR consumes: key_wallet::ReservationToken, ReservationSet::reserve/release_if_owner, TransactionBuilder::build_{unsigned,signed}_reserved, ManagedCoreFundsAccount::release_reservation_if_owner, and AssetLockResult.reservation_token. Previously pinned to bfoss765/rust-dashcore because the API existed only on the fork branch before dashpay#916 merged. Now repointed to the canonical upstream repo (no personal-fork dependency). 8f78baa6 is a strict descendant of v4.2-dev's prior pin 70d4bf8, so this is a forward-only bump. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
SimplifiedMasternodeListDAPIAddressProvider test prevents tests to be passed
What was done?
Fixed broken SimplifiedMasternodeListDAPIAddressProvider test
How Has This Been Tested?
With tests
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only