fix(dashmate): config/core/rpc/allowIps must be array - #881
Merged
Conversation
shumkov
requested changes
Apr 3, 2023
shumkov
requested changes
Apr 18, 2023
shumkov
requested changes
Apr 19, 2023
pshenmic
marked this pull request as ready for review
June 5, 2023 14:45
Collaborator
Author
|
Test results: I was tesing on my local via setting different config options: |
shumkov
requested changes
Jun 6, 2023
shumkov
reviewed
Jun 6, 2023
shumkov
requested changes
Jun 6, 2023
shumkov
pushed a commit
that referenced
this pull request
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
When dashmate config option is an array or object, command fails with
InvalidOptionPathError: config/core/rpc/allowIps must be array, because its expecting a stringWhat was done?
Conditionally parse string as JSON when its necessary
How Has This Been Tested?
Locally
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only