docs: supported Node.JS version and dashmate command description - #825
Merged
jaboski merged 13 commits intoMar 20, 2023
Merged
Conversation
thephez
requested changes
Mar 15, 2023
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
thephez
reviewed
Mar 16, 2023
thephez
left a comment
thephez
left a comment
Collaborator
There was a problem hiding this comment.
A few more questions/suggestions to consider
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
thephez
previously approved these changes
Mar 16, 2023
shumkov
changed the title
jaboski
deleted the
docs/update_supported_node_version_and_dashmate_command_descr
branch
March 20, 2023 15:28
QuantumExplorer
added a commit
that referenced
this pull request
Aug 22, 2026
…is reads The ranked and having-range executors only rank — every entry was projected to its (value, key) pair and the resolved primary value discarded — yet the resolving reads paid up to k primary point reads per page through the caller's transaction, outside the pinned iterator view the page came from, so a primary deleted or rewritten by a commit in between could surface as CorruptedData or pair a newer primary with an older page. grovedb's keys-only reads (dashpay/grovedb#824, indexed_*_top_k_paginated_keys / indexed_*_range_keys) return the ranking pairs straight from the secondary view and never open the primary; the executors and the e2e test helpers use them. grovedb pinned to develop head f52adb64, which also carries the append-only storage accounting (dashpay/grovedb#822 via #825/#826: write churn reported as replaced bytes, each note's permanent bytes charged once) and the keys-only projection on the unified PathQuery (#827). The genesis shielded seeding test passes the grove version to the commitment tree's save/commit_mmr, which now take it. The two shielded fee-floor tests (flat fee >= estimated write cost) remain red at this pin: the estimate for a 1-action transfer is now ~397M credits (storage 133M + processing 264M, the epoch's replaced bytes at the processing rate) against the 131M flat fee — down from 18.5B at the previous pin, and the subject of the shielded pricing change that follows this PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
As we are not supporting higher than 16 version of nodeJS, the documentation for platform is misleading.
Dashmate reset command description is also wrongly placed and mixed with reindex command.
What was done?
Update platform, DAPI and dashmate docs about currently supported nodeJS version (from v16+ to v16).
Fix incorrect description for dashmate
resetcommand which was partly pasted into reindex command description.How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only