feat(sdk-ffi): ask one evonode for its DAPI status; expose the platform HTTP port - #4461
Merged
Merged
Conversation
…rm HTTP port `dash_sdk_evonode_get_status(handle, "https://<ip>:<port>")` sends DAPI `getStatus` to that single node (rs-sdk `EvoNodeStatus::fetch_unproved` over `EvoNode`, one-connection pool, no address-list failover) and returns every field of the self-report as JSON: software/protocol versions, node id + proTxHash, chain heights/hashes, network, state sync, time. Request settings are bounded for a single-node probe — 10 s connect, 15 s request, one retry, no ban — so an offline node fails in ~20 s instead of the OS TCP timeout. Timestamps pass through raw; the Swift model documents the units (Drive `block`/`genesis` in ms with `0` = unknown, `local` in seconds from rs-dapi and ms from the JS DAPI). To address a wallet's own evonode, the masternode aggregation now carries the platform HTTP port from the latest ProRegTx / ProUpServTx alongside the service address (`MasternodeEntryFFI.platform_http_port` / `has_platform_http_port`). Swift SDK: `PlatformMasternode.platformHTTPPort` + `platformDAPIAddress` (`https://<service host>:<port>`), a typed `EvonodeStatus` (Codable), and `SDK.getEvonodeStatus(address:)` — nonisolated/blocking like `Identities.getBalance`, for callers to run off the main actor. Tests: FFI JSON shape (every field, omitted ⇒ null), null/invalid-address errors, an ignored live mainnet probe; aggregation latest-wins for the port; Swift decoding, time-unit accessors, and DAPI address building. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer
requested review from
ZocoLini,
lklimek,
llbartekll and
shumkov
as code owners
August 23, 2026 10:04
Contributor
|
Warning Review limit reached
Next review available in: 28 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
Collaborator
|
🕓 Ready for review — next in queue (commit 552dcd9) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.2-dev #4461 +/- ##
============================================
- Coverage 87.56% 87.40% -0.17%
============================================
Files 2698 2698
Lines 344559 344559
============================================
- Hits 301719 301150 -569
- Misses 42840 43409 +569
🚀 New features to boost your workflow:
|
bfoss765
added a commit
that referenced
this pull request
Aug 23, 2026
Brings the branch up to date with upstream after #4451 (masternode credit withdrawals), #4452, #4453, #4456, and #4461 landed on v4.2-dev. One conflict, in packages/rs-platform-wallet/src/wallet/core/mod.rs: a module-registration collision where this branch adds 'pub mod spend_observer;' and upstream adds 'pub(crate) use sign_message::is_signable_funding_account;' at the same spot. Resolved as the union — both lines kept, no semantic overlap. Auto-merged overlaps verified by hand: both error.rs files and DashSdkError.kt gained disjoint additions (upstream's MasternodeWithdrawalUnconfirmed / FFI code 42 alongside this branch's StaleReservation reusing code 34 — codes distinct, both mapping arms present). generation.rs (the broadcast-fence redesign) was touched by this branch only. Verified: cargo check -p platform-wallet -p platform-wallet-ffi clean; cargo test -p platform-wallet wallet::core::generation — 15/15 passed, including the settle-boundary and handoff tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bfoss765
added a commit
that referenced
this pull request
Aug 23, 2026
Brings the shielded-invite branch up to date with upstream v4.2-dev (#4451 masternode credit withdrawals, #4452, #4453, #4456, #4461). One conflict, in rs-platform-wallet/src/wallet/shielded/operations.rs: upstream #4451 moved carries_consensus_rejection() and broadcast_definitely_failed() out of operations.rs into the new shared crate::broadcast_outcome module (so masternode withdrawals can reuse them), while this branch had inserted its one-time-key claim machinery (NullifierSpentStatus, claim-evidence resolution) directly after those functions. Resolved by dropping the now-local duplicate of broadcast_definitely_failed() — its body is byte-identical to the moved copy, and the file already imports both helpers from crate::broadcast_outcome via upstream's auto-merged use line — and keeping this branch's one-time-key claim block in place. No semantic changes to either side. Verified: cargo check -p platform-wallet -p platform-wallet-ffi -p rs-unified-sdk-jni clean; cargo test -p platform-wallet --features shielded wallet::shielded = 205 passed, 0 failed (includes the one_time_claim_evidence and note_selection suites). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer
added a commit
to dashpay/dashwallet-ios
that referenced
this pull request
Aug 24, 2026
…s on demand (#1043) Adds a "Request status" row to the evonode detail screen. Tapping it pushes `EvonodeStatusScreen`, which sends DAPI `getStatus` to that node alone (`https://<service host>:<platform HTTP port>` — the SDK's new `PlatformMasternode.platformDAPIAddress`) and lists everything the node answered, grouped as the node groups it: Request (address asked, time received), Software (DAPI/Drive/Tenderdash), Protocol versions, Node (node id, proTxHash, an identity check against the masternode being viewed), Chain (catching up, heights, hashes), Network (chain id, peers, listening), State sync, Time (node clock, latest block, genesis, epoch). Optional fields the node omitted read "Not reported". Hashes/addresses are tap-to-copy. Nothing is requested automatically: the request is sent only when the user taps the row (and again on the screen's Refresh / Try again). The row is disabled with the reason when the aggregation doesn't know the node's DAPI address. An unreachable node shows the transport error and a Try again button (~20 s with the SDK's single-node timeouts). `EvonodeStatusViewModel` owns the SDK call (`SDK.getEvonodeStatus`, run off the main actor) and the row layout/formatting; the view only renders. `MasternodeDetailRow` / `MasternodeCopyRow` become internal and are reused. Requires dashpay/platform#4461 (FFI `dash_sdk_evonode_get_status`, `platform_http_port` in the masternode aggregation, Swift `EvonodeStatus`). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets a wallet ask one specific evonode for its DAPI
getStatusself-report, and gives the wallet what it needs to address its own evonodes.dash_sdk_evonode_get_status(handle, "https://<ip>:<port>")(rs-sdk-ffi) — sendsgetStatusto that single node via rs-sdk'sEvoNodeStatus::fetch_unproved(EvoNode)(one-connection pool, no address-list failover) and returns every field of the report as JSON: software/protocol versions, node id + proTxHash, chain heights/hashes, network, state sync, time. Hashes hex, omitted optionalsnull.block/genesisare ms (0= unknown genesis),localis seconds from rs-dapi and ms from the legacy JS DAPI — the Swift model encodes that once (Time.localDate/blockDate/genesisDate, magnitude-disambiguated,0 → nil).MasternodeEntryFFI.platform_http_port+has_platform_http_port, from the latest ProRegTx / ProUpServTx together with the service address (same latest-wins rule).PlatformMasternode.platformHTTPPort+platformDAPIAddress(https://<service host>:<port>, IPv6 bracketed), typedEvonodeStatus(Codable, every field),SDK.getEvonodeStatus(address:)— deliberately in its own nonisolated extension (thePlatformQueryExtensionsextension is@MainActor; this is a blocking FFI call callers run off-main, likeIdentities.getBalance).Consumer: dashpay/dashwallet-ios "Request status" button on the evonode detail screen (PR to follow).
Test plan
cargo test -p rs-sdk-ffi --lib evonode::queries::status— JSON carries every field / omitted ⇒ null, null handle / null address / invalid address error codes.cargo test -p rs-sdk-ffi --lib evonode::queries::status -- --ignored— live mainnet probe (https://31.220.91.60:443): full report in 1.1 s, heights/chain id asserted.cargo test -p platform-wallet-ffi --lib core_wallet_types— port follows ProRegTx then ProUpServTx; FFI entry gated byhas_platform_http_port.cargo fmt --all --check;cargo clippy -p rs-sdk-ffi -p platform-wallet-ffi --all-targets --all-features --locked -- --no-deps -D warnings.xcodebuild test -scheme SwiftDashSDK -only-testing:SwiftDashSDKTests/EvonodeStatusTests— 6/6 (decoding, omitted fields, time units, DAPI address incl. IPv6)../build_ios.sh --target sim+ SwiftExampleApp compiles with-warnings-as-errors.🤖 Generated with Claude Code