Skip to content

chore: bump rust-dashcore to the merged sync fixes, minus the sweep-event chain #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romchornyi wants to merge 1 commit into
base: v4.2-dev
Choose a base branch
from
+31 −31
Open

chore: bump rust-dashcore to the merged sync fixes, minus the sweep-event chain #4459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@ members = [
]

[workspace.dependencies]
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "a97b32c617c8b1fef5185bb806500b66faf8e8c4" }
dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "a97b32c617c8b1fef5185bb806500b66faf8e8c4" }
dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "a97b32c617c8b1fef5185bb806500b66faf8e8c4" }
key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "a97b32c617c8b1fef5185bb806500b66faf8e8c4" }
key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "a97b32c617c8b1fef5185bb806500b66faf8e8c4" }
key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "a97b32c617c8b1fef5185bb806500b66faf8e8c4" }
dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "a97b32c617c8b1fef5185bb806500b66faf8e8c4" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "a97b32c617c8b1fef5185bb806500b66faf8e8c4" }
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "1322ef7252fe00cbe941a574c78fe94d755c27cd" }
dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "1322ef7252fe00cbe941a574c78fe94d755c27cd" }
dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "1322ef7252fe00cbe941a574c78fe94d755c27cd" }

@thepastaclaw thepastaclaw Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Blocking: Historical filter rescan permits peer-driven memory and bandwidth exhaustion

The newly pinned revision includes rust-dashcore commit 2dc97c57 (#866), which was absent from the previous pin. Its rescan_committed_range loads history in 5,000-filter chunks but inserts every match from the wallet birth height through batch_start - 1 into one BTreeMap; it does not drain matches until the entire range has been scanned. queue_new_script_matches then duplicates that chain-length state into the tracker and a BlocksNeeded event, and BlocksManager queues every missing block for download. This is reachable for Platform recovery wallets because birth_height_override = Some(0) explicitly enables scans from genesis. The filter-header manager accepts peer-provided CFHeaders, computes their self-consistent chain, and stores it without an independently authenticated checkpoint, while filters are only checked against that same peer-provided chain. An eclipsing compact-filter peer can therefore construct historical filters that avoid the current watch set but match a receive script that a later valid payment causes gap-limit maintenance to derive. At the current multi-million-block chain length, the backward sweep can exhaust mobile memory before emitting its event; if it survives, it schedules millions of full-block reads or downloads. Preserve the historical rescan cursor and process a bounded number of matches per iteration, with an explicit cap or recovery policy for implausibly high match rates, or repin without #866 until that upstream fix is available.

source: ['codex']

key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "1322ef7252fe00cbe941a574c78fe94d755c27cd" }
key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "1322ef7252fe00cbe941a574c78fe94d755c27cd" }
key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "1322ef7252fe00cbe941a574c78fe94d755c27cd" }
dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "1322ef7252fe00cbe941a574c78fe94d755c27cd" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "1322ef7252fe00cbe941a574c78fe94d755c27cd" }

tokio-metrics = "0.5"

Expand Down
Loading