Skip to content

fix(swift-sdk): build the shippable profile by default #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romchornyi wants to merge 2 commits into
base: v4.2-dev
Choose a base branch
from
+23 −4
Open

fix(swift-sdk): build the shippable profile by default #4371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
109e5c9
fix(swift-sdk): build the shippable profile by default
jeanpierreroma Aug 11, 2026
5732d96
Merge branch 'v4.2-dev' into fix/ship-release-profile-by-default
romchornyi Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ Quick build commands:
```bash
# Build unified iOS framework (includes Core + Platform)
cd packages/swift-sdk
./build_ios.sh
./build_ios.sh --target sim # release profile (the default)
./build_ios.sh --target sim --profile dev # local iteration ONLY — debug
# assertions abort the host app

# Build SwiftExampleApp
cd packages/swift-sdk
Expand Down
23 changes: 20 additions & 3 deletions packages/swift-sdk/build_ios.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export MACOSX_DEPLOYMENT_TARGET
# -------------------------------
RED="\033[0;31m"
GREEN="\033[0;32m"
YELLOW="\033[0;33m"
NC="\033[0m"

# -------------------------------
Expand All @@ -23,7 +24,7 @@ ROOT_DIR="$SCRIPT_DIR/../../"
TARGET_DIR="$ROOT_DIR/target"
PACKAGE="rs-unified-sdk-ffi"
XCFRAMEWORK="$SCRIPT_DIR/DashSDKFFI.xcframework"
PROFILE="dev"
PROFILE="release"
PRUNE_CARGO_TARGETS="${PRUNE_CARGO_TARGETS:-0}"
STAGING_DIR=""

Expand All @@ -47,6 +48,7 @@ CLEAN=false

log_info() { echo -e "${GREEN}$1${NC}"; }
log_error() { echo -e "${RED}$1${NC}"; }
log_warn() { echo -e "${YELLOW}$1${NC}"; }

cleanup_staging_dir() {
if [ -n "$STAGING_DIR" ]; then
Expand Down Expand Up @@ -87,8 +89,11 @@ show_help() {
echo " tests -> targets needed by run_tests.sh (sim + mac)"
echo ""
echo "Profile:"
echo " dev (default)"
echo " release"
echo " release (default) -> ships: optimized, no debug assertions"
echo " dev -> local iteration: fast to build, debug"
echo " assertions ON, tokio-metrics ON. A dev"
echo " build turns every internal invariant into"
echo " an abort() and must never be distributed."
echo ""
echo "Examples:"
echo " $0 --target sim --profile release"
Expand Down Expand Up @@ -154,6 +159,18 @@ OUTPUT_DIR="$PROFILE"
log_info "Package: $PACKAGE"
log_info "Profile: $PROFILE"

# `dev-ios` inherits Cargo's `dev` defaults, so debug assertions are live —
# and it pairs them with `panic = "abort"`. Any debug_assert! in dash-spv,
# key-wallet or platform-wallet therefore terminates the host process rather
# than degrading. That is what a dev build is for locally, and exactly why one
# must not reach testers; a shipped dev build has already crashed a TestFlight
# release this way. Loud on purpose, since the failure is invisible until a
# device aborts weeks later.
if [ "$PROFILE" = "dev-ios" ]; then
log_warn "dev profile: debug assertions ON (panic = abort) — NOT distributable"
log_warn " build shipping artifacts with: $0 --target all --profile release"
fi

if [ "$PRUNE_CARGO_TARGETS" = "1" ]; then
STAGING_DIR="$(mktemp -d "${TMPDIR:-/tmp}/dash-sdk-ffi.XXXXXX")"
trap cleanup_staging_dir EXIT
Expand Down
Loading