-
Notifications
You must be signed in to change notification settings - Fork 56
feat(kotlin-sdk): coinjoin-drain shielded funding binding + typed asset-lock shortfall #4361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bfoss765
wants to merge
6
commits into
v4.2-dev
Choose a base branch
from
feat/coinjoin-drain-android-bindings
base: v4.2-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a711c55
feat(kotlin-sdk): CoinJoin-drain shielded funding binding + typed ass…
bfoss765 bf9a134
fix(platform-wallet): report the drain floor, not the zero placeholde…
bfoss765 89a97be
Merge branch 'tmp-v42dev' into tmp-4361
bfoss765 fc97ca3
docs(platform-wallet): drain shortfalls report the configured floor, …
bfoss765 18ce5d8
docs(platform-wallet): asset-lock shortfalls span the pooled sources …
bfoss765 35dbd8c
style(platform-wallet): rustfmt the DrainAll shortfall match arm
bfoss765 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Suggestion: Shortfall documentation contradicts pooled asset-lock funding
These new public docs say
availablealways describes one selected account and that asset-lock funding never unions accounts. The exact-amount path callsbuild_asset_lock_transaction_with_fundingwithASSET_LOCK_FUNDING_SOURCES, which explicitly pools the BIP44 and BIP32 accounts plus every DashPay contact-receiving account; a builder shortfall can therefore describe that permitted union. OnlyDrainAccountBalance, including the CoinJoin migration, selects exactly one account. Update this documentation and the matching new FFI and Kotlin comments so hosts do not present an exact-amount pooled shortfall as a single-account failure.source: ['codex']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 18ce5d8 — docs corrected to the funding truth verified in code: available spans the pooled BIP44+BIP32+contact-receiving union on exact-amount asset-lock builds (ASSET_LOCK_FUNDING_SOURCES = SEND_FUNDING_SOURCES), and is single-account only on drains (CoinJoin sole form; never pooled). Same correction in the FFI code-29 docs, DashSdkError KDoc, and the test narrative; also repaired two pre-existing broken intra-doc links in the same block (cargo doc warnings 123 -> 121).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in
18ce5d8— Shortfall documentation contradicts pooled asset-lock funding no longer present.Auto-resolved by the review system based on the latest commit diff. If you believe this was closed in error, reopen the thread.